fix(modules): fix issue with modules not on root folder having keys w… #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith extra / and not updating the dinghyfile on changes
|
Related to: |
|
Adding Jossue and Fernando for reviewing |
|
Thanks for fixing this btw Karlo - really appreciate it! |
|
Is there a unit test that can be added for this? Maybe a test with a sample input file that failed before but now succeeds? |
dogonthehorizon
pushed a commit
that referenced
this pull request
Mar 30, 2021
#89) * fix(modules): fix issue with modules not on root folder having keys with extra / and not updating the dinghyfile on changes * test(): add test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ith extra / and not updating the dinghyfile on changes