Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue #2 #3

Merged
merged 1 commit into from
Dec 10, 2018
Merged

Fix issue #2 #3

merged 1 commit into from
Dec 10, 2018

Conversation

const-ae
Copy link
Contributor

  • Set sort=FALSE in merge call in test_diff to make sure that p-values are in the correct order.
  • Previously it only returned the correct order if the rows of the SummarizedExperiment were ordered alphabetically
  • Add test to confirm that behavior is correct now

@const-ae
Fix issue arnesmits#2
8cf41a8 
- Set sort=FALSE to make sure that p-values are in the correct order.
- Previously it only returned the correct order if the rows of the SummarizedExperiment were ordered alphabetically
- Add test to confirm that behavior is correct now
@arnesmits arnesmits merged commit ae80fbd into arnesmits:master Dec 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@const-ae @arnesmits