Added support for flycheck. #35
Conversation
The buffer could be in some derived mode that flycheck wont activate the checker for, which results in errors if we try to enforce it.
| @@ -0,0 +1,98 @@ | |||
| ;;; drupal/flymake-phpcs.el --- Drupal-mode support for flymake-phpcs | |||
There was a problem hiding this comment.
The file name and the summary are obviously wrong…
There was a problem hiding this comment.
By the way, would you mind to rename this file? I might break Flycheck, if the drupal/ directory is by some accident added to load-path before the package directory of Flycheck. I know that this is somewhat unlikely, but still possible, and can easily be avoided.
There was a problem hiding this comment.
I changed the documentation and summary when I merged the change to develop. See 4f54f8b.
There was a problem hiding this comment.
Ah, the joys of copy and paste.
@arnested probably have an opinion on how these files should be named. I also introduced some inconsistency when moving things about.
|
@lunaryorn thanks for the review. |
Adresses #30.
With a custom checker for checking CSS/JS with phpcs.