Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RF launcher demo #14

Merged
merged 1 commit into from
Dec 30, 2014
Merged

RF launcher demo #14

merged 1 commit into from
Dec 30, 2014

Conversation

jeremygray
Copy link
Contributor

  • provide a 'quit' button
  • add place-holder tool-tips; could add more documentation here
  • parameterize button creation: simplifies code, uses eval() but only for known values

- include 'quit' button
- parameterize button creation
@aroberge
Copy link
Owner

Seeing the removal of the repetitive code (I should have noticed as I started by copying-pasting code each time I added a widget), I feel greatly humbled (to not say dumb...).

aroberge added a commit that referenced this pull request Dec 30, 2014
@aroberge aroberge merged commit 18cb80e into aroberge:master Dec 30, 2014
@jeremygray
Copy link
Contributor Author

Seeing the removal of the repetitive code (I should have noticed as I
started by copying-pasting code each time I added a widget), I feel greatly
humbled (to not say dumb...).

I feel happy to have my little code snippets included in your project! Some
people are deeply averse to using eval(), but I think it makes life more
pythonic here.

By reading your code, I'm learning about pyqt and python 3. Thanks for
putting this out there, I'm learning a lot from you, André.

@aroberge
Copy link
Owner

eval() is there for a reason ... and your use seems like an excellent reason to use it! (although, I just thought of a possible way to remove it ... if only to please the "purists"). And, your idea to have tooltips is excellent (I never used them with PyQt before) ... I may just have abused them in the latest commit!

@aroberge
Copy link
Owner

Yes, it seems possible to use eval. Since you used it, I suspect you did not know of the method I used.

@jeremygray jeremygray deleted the rf-launcher-demo branch December 30, 2014 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants