Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

on/off option for scrollTo #1

Closed
chrtz opened this issue Apr 5, 2019 · 6 comments
Closed

on/off option for scrollTo #1

chrtz opened this issue Apr 5, 2019 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@chrtz
Copy link

chrtz commented Apr 5, 2019

First things first – I highly appreciate your work. this is the first approach which is finally working in my project. It's deadly simple to handle and straightforward.

I’d just like to ask for an upcoming feature:
Option to disable all the scrollTo features. In my case the CSS property scroll-behaviour: smooth; would be totally enough.

Regards

@danielchodusov danielchodusov added the enhancement New feature or request label Apr 5, 2019
@danielchodusov
Copy link
Contributor

Hi thanks for your feedback, really appreciated that you like this package!

About the feature request. You would like to have an option to disable the "smooth scroll" but keep the "spy scroll" (adding active class on menu when scrolling over section) feature? Am I right?

@danielchodusov danielchodusov self-assigned this Apr 5, 2019
@chrtz
Copy link
Author

chrtz commented Apr 5, 2019

Exactly.
Having all the smooth scroll/scrollTo features optional would be a huge benefit.
Navspa would be even more flexible.

danielchodusov added a commit that referenced this issue Apr 5, 2019
@danielchodusov
Copy link
Contributor

Added in 1.2.0 you can use it as:

<nav-spa :enabled-smooth-scroll="false"> 

which disables smooth scroll but keep the spy scroll. Check if it works, as you expected! :)

@chrtz
Copy link
Author

chrtz commented Apr 7, 2019

I updated the package and tried to use the enable-smooth-scroll but whether I switch it to true/false, I doesn’t change anything, yet. It’s still enabled.

@danielchodusov
Copy link
Contributor

Hi chrtz!

Sorry It seems I haven't seen your reply in this thread. Have you managed to get this worked?

@chrtz
Copy link
Author

chrtz commented Nov 8, 2019

Totally forgot abut this - I think I used CSS smooth-scroll instead.

EDIT: I double checked it again, it's working for sure now!

@chrtz chrtz closed this as completed Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants