-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ellipsis not mentioned in docs #22
Comments
Thanks! I am not mentioning this in the docs for purpose as I expect this feature to be misused. |
+1 I think support for ellipsis is noteworthy. In fact, I recently saw someone note support for ellipsis as a missing feature in einops! It's true that it's probably a better idea to omit ellipsis when writing code specialized for particular shapes of arrays, but occasionally it's nice to write rank polymorphic code and there's no good alternative to it. |
I also agree that this should be documented! Sometimes you have to reshape an array with an undefined number of axes, and I don't think there's any other way to do it with einops? Eg |
I was initially a little disappointed after not finding ellipsis support in the docs, as it was crucial for my application and I was really enjoying |
|
I was just going to open a feature request for I think the ellipsis notation can be turned even more powerful by adding the ability to name the axes group and add an explicit count. E.g.,
An undetermined count (what |
I agree with everyone. If there is a concern for misuse, we could have a paragraph informing the user about best practices. |
I'm here because ellipsis are used in StableDiffusion code, and I had a hard time understanding since I couldn't find in the docs. |
In the mean time you can find some usage of ellipsis in the einops paper : Rogozhnikov, Alex. "Einops: Clear and reliable tensor manipulations with einstein-like notation." International Conference on Learning Representations. 2021. |
I'm here because ellipsis are used in FlashAttention. It's hard for non-native English speakers to know the word "ellipsis", let alone find the correct page to explain what it means in |
Great work!
I discovered in https://github.com/arogozhnikov/einops/blob/master/einops/einops.py#L199 that you also support ellipsis. Its an important feature so you may want to add it to the documentation.
The text was updated successfully, but these errors were encountered: