Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to zulip-js #23

Closed
arpith opened this issue Feb 27, 2018 · 1 comment · Fixed by #28
Closed

Switch to zulip-js #23

arpith opened this issue Feb 27, 2018 · 1 comment · Fixed by #28

Comments

@arpith
Copy link
Owner

arpith commented Feb 27, 2018

Currently the blocker is that graceful-fs and fs-readfile-promise need to be ignored.

In webpack, this was achieved by using externals

According to this links, parcel should support this in package.json / browser
parcel-bundler/parcel#200
https://github.com/defunctzombie/package-browser-field-spec

The other alternative is to ignore the files using babel alias (?!)
parcel-bundler/parcel#144

@arpith
Copy link
Owner Author

arpith commented Mar 8, 2018

fs-readfile-promise is ignored in zulip/zulip-js@e3f7c4b

5de3ddd switches to zulip/zulip-js (git install)

presumably, 2.0.3 will be the npm version that can be switched to

arpith added a commit that referenced this issue Mar 26, 2018
arpith added a commit that referenced this issue Mar 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant