Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "Already have an account" link to the sign-up page #11 #22

Merged
merged 5 commits into from
Jul 5, 2023

Conversation

tech-hao
Copy link
Contributor

@tech-hao tech-hao commented Jul 5, 2023

The purpose of this pull request is to add an "Already have an account" link to our sign-up page, providing users with a convenient way to navigate to the login page. This link will be placed below the sign-up form, assisting users in quickly finding the option to log in.
To achieve this goal, the following changes have been made:

  • Added a new hyperlink at the bottom of the sign-up page with the text "Already have an account log in"

  • Set the target URL of the link to the login page to ensure that users are redirected to the login page upon clicking the link.

The purpose of this change is to enhance the user experience and provide users with more options and flexibility during the sign-up process.

screen shot

  • before
    image
  • after
    image

@vercel
Copy link

vercel bot commented Jul 5, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @arpittyagi102 on Vercel.

@arpittyagi102 first needs to authorize it.

Copy link
Owner

@arpittyagi102 arpittyagi102 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, Thank you so much for your contribution, I am merging this PR
please give this repository a star 🌟

@vercel
Copy link

vercel bot commented Jul 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
link-up ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 5, 2023 11:23am

Copy link
Owner

@arpittyagi102 arpittyagi102 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @moonlight0301, i think you forgot to add

import { Link } from react-router-dom

The code is showing this error on vercel :

12:57:13.000 | Failed to compile.
12:57:13.001 | [eslint]
12:57:13.001 | src/Pages/SignupPage/SignupPage.jsx
12:57:13.001 | Line 151:38:  'Link' is not defined  react/jsx-no-undef
12:57:13.001 |  
12:57:13.001 | Search for the keywords to learn more about each error.
12:57:13.001 |  
12:57:13.002 |  
12:57:13.042 | Error: Command "npm run build" exited with 1

Copy link
Contributor Author

@tech-hao tech-hao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for pointing my mistake. I have changed the file.

Copy link
Owner

@arpittyagi102 arpittyagi102 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, All done

@arpittyagi102 arpittyagi102 merged commit 77009c7 into arpittyagi102:master Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants