Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use glad, glm system packages automatically if available #226

Merged
merged 2 commits into from
Apr 22, 2021

Conversation

9prady9
Copy link
Member

@9prady9 9prady9 commented Apr 22, 2021

  1. Use glad, glm system packages automatically if available, otherwise use FetchContent from CMake is used to retrieve the source code for glm and glad during CMake configure time. This change also added glm, glad to vcpkg manifest file. Tested the cmake logic in the following scenarios:
  • glad and glm are available via package manager like vcpkg
  • One of the two, glad and glm, is only available via package manager
  • None of the two, glad and glm are not installed on the system

2. Increased min required C++ standard to C++17, examples are still C++11 though
3. Use correct LINK keyword for static freeimage linking

In the case they aren't, then FetchContent from CMake is used to
retrieve the source code for glm and glad during CMake configure time.

Tested the cmake logic in the following scenarios:
- glad and glm are available via package manager like vcpkg
- One of the two, glad and glm, is only available via package manager
- None of the two, glad and glm are not installed on the system

This change also added glm, glad to vcpkg manifest file
@9prady9 9prady9 merged commit 5d30e3b into arrayfire:master Apr 22, 2021
@9prady9 9prady9 deleted the use_vcpkg_deps branch April 22, 2021 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant