Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type reference quote and template scope #132

Merged
merged 3 commits into from
Nov 22, 2019
Merged

Type reference quote and template scope #132

merged 3 commits into from
Nov 22, 2019

Conversation

ahinchman1
Copy link
Collaborator

Checklist for KtTypeReference

  • Added/replaced the inverse element in ElementScope
  • Destructure and make available all methods related to rendering properties, but no logic
  • Add documentation for element

@ahinchman1 ahinchman1 mentioned this pull request Nov 13, 2019
Open
43 tasks
@ahinchman1 ahinchman1 force-pushed the type-reference-quote-and-template-scope branch 2 times, most recently from aca509a to b8baedd Compare November 19, 2019 18:07
@ahinchman1 ahinchman1 force-pushed the type-reference-quote-and-template-scope branch from b8baedd to 808f626 Compare November 19, 2019 18:31
@ahinchman1 ahinchman1 added the AST-scope AST elements for the quote system label Nov 20, 2019
@ahinchman1 ahinchman1 self-assigned this Nov 20, 2019
@ahinchman1 ahinchman1 force-pushed the type-reference-quote-and-template-scope branch 3 times, most recently from 60e3b66 to c78e635 Compare November 21, 2019 15:56
@ahinchman1 ahinchman1 force-pushed the type-reference-quote-and-template-scope branch from c78e635 to 27c9f34 Compare November 22, 2019 19:08
@ahinchman1 ahinchman1 merged commit 6efde4a into master Nov 22, 2019
@ahinchman1 ahinchman1 deleted the type-reference-quote-and-template-scope branch November 22, 2019 19:19
raulraja
raulraja reviewed Nov 22, 2019
View reviewed changes
compiler-plugin/src/main/kotlin/arrow/meta/quotes/TypeAlias.kt
@@ -27,7 +27,7 @@ fun Meta.typeAlias(
*/
class TypeAlias(
override val value: KtTypeAlias,
val `@annotations`: ScopedList<KtAnnotationEntry> = ScopedList(value.annotationEntries),
val `@annotationEntries`: ScopedList<KtAnnotationEntry> = ScopedList(value.annotationEntries),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what happened here but we want to preserve the name annotations vs annotationEntries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulraja raulraja raulraja left review comments

@bloderxd bloderxd Awaiting requested review from bloderxd

Assignees

@ahinchman1 ahinchman1

Labels
AST-scope AST elements for the quote system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahinchman1 @raulraja