Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch quote and scope #152

Merged
merged 3 commits into from
Nov 16, 2019
Merged

Catch quote and scope #152

merged 3 commits into from
Nov 16, 2019

Conversation

bloderxd
Copy link
Collaborator

@bloderxd bloderxd commented Nov 15, 2019 •
edited
Loading

This PR introduces KtCatchClause quote and its scope mapping. This PR is related to #89

Checklist for KtCatchClause

  • Added/replaced the inverse element in ElementScope
  • Destructure and make available all methods related to rendering properties, but no logic
  • Add documentation for element

@bloderxd bloderxd added the AST-scope AST elements for the quote system label Nov 15, 2019
@ahinchman1 ahinchman1 mentioned this pull request Nov 15, 2019
Open
43 tasks
raulraja
raulraja approved these changes Nov 16, 2019
View reviewed changes
Copy link
Member

@raulraja raulraja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@bloderxd bloderxd merged commit c769fac into arrow-kt:master Nov 16, 2019
@bloderxd bloderxd deleted the catch-quote branch November 16, 2019 15:13
@bloderxd bloderxd mentioned this pull request Nov 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulraja raulraja raulraja approved these changes

Assignees
No one assigned
Labels
AST-scope AST elements for the quote system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bloderxd @raulraja