Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PackageDirective quote and scope #336

Merged
merged 4 commits into from
Dec 15, 2019
Merged

PackageDirective quote and scope #336

merged 4 commits into from
Dec 15, 2019

Conversation

bloderxd
Copy link
Collaborator

Checklist for KtPackageDirective

  • Added/replaced the inverse element in ElementScope
  • Destructure and make available all methods related to rendering properties, but no logic
  • Add documentation for element
  • Testing added for validation to ensure all properties can be used as a commutative identity

#89

@bloderxd bloderxd added documentation Improvements or additions to documentation AST-scope AST elements for the quote system labels Dec 14, 2019
@bloderxd bloderxd self-assigned this Dec 14, 2019
@ahinchman1 ahinchman1 mentioned this pull request Dec 14, 2019
Open
43 tasks
raulraja
raulraja approved these changes Dec 15, 2019
View reviewed changes
Copy link
Member

@raulraja raulraja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@raulraja raulraja merged commit e1fd038 into arrow-kt:master Dec 15, 2019
@bloderxd bloderxd deleted the package-directive-quote branch December 15, 2019 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulraja raulraja raulraja approved these changes

@ahinchman1 ahinchman1 Awaiting requested review from ahinchman1

Assignees

@bloderxd bloderxd

Labels
AST-scope AST elements for the quote system documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bloderxd @raulraja