Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic navigation structure #26

Merged
merged 4 commits into from
Feb 22, 2023
Merged

Conversation

calvellido
Copy link
Member

@calvellido calvellido commented Feb 21, 2023

This PR includes some starting foundations for the site:

  • It adds some basic styling such as colours, headings, adjust the element's global radius… And it also includes the Inter typography in a variable set, to be used along all the site. It also updates the site to show Kotlin code snippets properly highlighted (colours theme to be updated in the future).

  • It makes the necessary changes in the navigation bar and the footer to include the proper links outlined in the site wireframes. It does so while also updating the pages placeholder template to make these pages use navbar and footer now.

  • It configures and start using a method to use YAML (*.yml files) as a data source for pages. I think this go in line with the front matter data for Markdown files in the docs and blog pages, which might make it easier for non-technical people to make changes in case they deemed necessary. The code for this is also very clean, and it looks exactly the same way as we import styles for the pages, which makes it reasonable.

@nomisRev
Copy link
Member

Screenshot 2023-02-21 at 19 00 08

Looking good! Thanks @calvellido 🙌

@israelperezglez
Copy link

Good Job buddy. I like this variable ;)

--ifm-global-radius: 0;

Captura de pantalla 2023-02-22 a las 8 36 59

@calvellido calvellido merged commit 67c4093 into main Feb 22, 2023
@calvellido calvellido deleted the calvellido-basic-foundations branch February 22, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants