Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update typed errors, CircuitBreaker & Schedule #88

Merged
merged 7 commits into from
Mar 21, 2023
Merged

Update typed errors, CircuitBreaker & Schedule #88

merged 7 commits into from
Mar 21, 2023

Conversation

nomisRev
Copy link
Member

@nomisRev nomisRev commented Mar 19, 2023 •
edited
Loading

  • Updates the document to use more real-life examples
  • Adds section on wrapping foreign functions
  • Adds section on how to wrap custom DSLs

@nomisRev nomisRev changed the title Update typed errors Update typed errors, CircuitBreaker & Schedule Mar 19, 2023
serras
serras approved these changes Mar 20, 2023
View reviewed changes
Copy link
Member

@serras serras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job clarifying many of the nuances of typed errors, and improving the readibility of the examples.

content/docs/learn/typed-errors/working-with-typed-errors.md Outdated Show resolved Hide resolved
content/docs/learn/typed-errors/working-with-typed-errors.md Outdated Show resolved Hide resolved
content/docs/learn/typed-errors/working-with-typed-errors.md Outdated Show resolved Hide resolved
content/docs/learn/typed-errors/working-with-typed-errors.md Outdated Show resolved Hide resolved
content/docs/learn/typed-errors/working-with-typed-errors.md Outdated Show resolved Hide resolved
@nomisRev @serras
Apply suggestions from code review
f65e536 
Co-authored-by: Alejandro Serrano <trupill@gmail.com>
@nomisRev
Copy link
Member Author

Thank you for the great suggestions @serras 🙏

franciscodr
franciscodr approved these changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@franciscodr franciscodr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff, @nomisRev!

@nomisRev @franciscodr
Apply suggestions from code review
7a942eb 
Co-authored-by: Francisco Diaz <francisco.d@47deg.com>
@nomisRev nomisRev merged commit 10ff6dc into main Mar 21, 2023
@nomisRev nomisRev deleted the update-typed-errors branch March 21, 2023 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franciscodr franciscodr franciscodr approved these changes

@serras serras serras approved these changes

@gutiory gutiory Awaiting requested review from gutiory

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nomisRev @serras @franciscodr