Skip to content

Commit

Permalink
Fix publishing Serialization, rename module functions to functions
Browse files Browse the repository at this point in the history
  • Loading branch information
nomisRev committed May 30, 2024
1 parent 506917b commit 5724286
Show file tree
Hide file tree
Showing 7 changed files with 14 additions and 111 deletions.
56 changes: 0 additions & 56 deletions arrow-libs/core/arrow-continuations/api/arrow-continuations.api

This file was deleted.

This file was deleted.

This file was deleted.

2 changes: 1 addition & 1 deletion arrow-libs/core/arrow-core-serialization/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
plugins {
id(libs.plugins.kotlin.multiplatform.get().pluginId)
alias(libs.plugins.arrowGradleConfig.kotlin)

alias(libs.plugins.publish)
alias(libs.plugins.kotlinx.kover)
alias(libs.plugins.spotless)
id(libs.plugins.kotlinx.serialization.get().pluginId)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ public inline fun <Error, A, B> EagerEffect<Error, A>.fold(recover: (error: Erro

/**
* The most general way to execute a computation using [Raise].
* Depending on the outcome of the block, one of the two continuations is run:
* Depending on the outcome of the block, one of the two lambdas is run:
* - _success_ [transform] result of [A] to a value of [B].
* - _raised_ [recover] from `raised` value of [Error] to a value of [B].
*
Expand All @@ -116,7 +116,7 @@ public inline fun <Error, A, B> fold(

/**
* The most general way to execute a computation using [Raise].
* Depending on the outcome of the block, one of the three continuations is run:
* Depending on the outcome of the block, one of the three lambdas is run:
* - _success_ [transform] result of [A] to a value of [B].
* - _raised_ [recover] from `raised` value of [Error] to a value of [B].
* - _exception_ [catch] from [Throwable] by transforming value into [B].
Expand Down Expand Up @@ -172,16 +172,16 @@ public inline fun <Error, A, B> fold(
* }
* ```
* ```text
* arrow.core.continuations.RaiseCancellationException: Raised Continuation
* at arrow.core.continuations.DefaultRaise.raise(Fold.kt:77)
* arrow.core.raise.RaiseCancellationException: Raised Continuation
* at arrow.core.raise.DefaultRaise.raise(Fold.kt:77)
* at MainKtKt$main$error$1.invoke(MainKt.kt:6)
* at MainKtKt$main$error$1.invoke(MainKt.kt:6)
* at arrow.core.continuations.Raise$DefaultImpls.bind(Raise.kt:22)
* at arrow.core.continuations.DefaultRaise.bind(Fold.kt:74)
* at arrow.core.continuations.Effect__TracingKt$traced$2.invoke(Traced.kt:46)
* at arrow.core.continuations.Effect__TracingKt$traced$2.invoke(Traced.kt:46)
* at arrow.core.continuations.Effect__FoldKt.fold(Fold.kt:92)
* at arrow.core.continuations.Effect.fold(Unknown Source)
* at arrow.core.raise.Raise$DefaultImpls.bind(Raise.kt:22)
* at arrow.core.raise.DefaultRaise.bind(Fold.kt:74)
* at arrow.core.raise.Effect__TracingKt$traced$2.invoke(Traced.kt:46)
* at arrow.core.raise.Effect__TracingKt$traced$2.invoke(Traced.kt:46)
* at arrow.core.raise.Effect__FoldKt.fold(Fold.kt:92)
* at arrow.core.raise.Effect.fold(Unknown Source)
* at MainKtKt.main(MainKt.kt:8)
* at MainKtKt.main(MainKt.kt)
* ```
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -389,7 +389,7 @@ class EffectSpec {
}
}

@Test fun issue2779HandleErrorWithDoesNotMakeNestedContinuationsHang() = runTest {
@Test fun issue2779HandleErrorWithDoesNotMakeNestedEffectHang() = runTest {
checkAll(Arb.string()) { error ->
val failed: Effect<String, Int> = effect {
withContext(Dispatchers.Default) {}
Expand All @@ -405,7 +405,7 @@ class EffectSpec {
}
}

@Test fun issue2779BindNestedInFoldDoesNotMakeNestedContinuationsHang() = runTest {
@Test fun issue2779BindNestedInFoldDoesNotMakeNestedEffectHang() = runTest {
checkAll(Arb.string()) { error ->
val failed: Effect<String, Int> = effect {
withContext(Dispatchers.Default) {}
Expand Down
2 changes: 1 addition & 1 deletion arrow-libs/core/arrow-functions/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ kotlin {
jvm {
tasks.jvmJar {
manifest {
attributes["Automatic-Module-Name"] = "arrow.continuations"
attributes["Automatic-Module-Name"] = "arrow.functions"
}
}
}
Expand Down

0 comments on commit 5724286

Please sign in to comment.