Kleisli and EitherT extra instances and tests + some fixes #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # kategory/src/test/kotlin/kategory/data/EitherTTest.kt
Codecov Report
@@ Coverage Diff @@
## master #127 +/- ##
=========================================
Coverage ? 55.85%
Complexity ? 212
=========================================
Files ? 90
Lines ? 1332
Branches ? 173
=========================================
Hits ? 744
Misses ? 514
Partials ? 74
Continue to review full report at Codecov.
|
JorgeCastilloPrz
approved these changes
Jul 16, 2017
pakoito
reviewed
Jul 16, 2017
| @@ -78,3 +78,51 @@ data class EitherT<F, A, B>(val MF: Monad<F>, val value: HK<F, Either<A, B>>) : | |||
| return GA.map(fa, { EitherT(MF, MF.map(it.lower(), { it.ev() })) }) | |||
| } | |||
| } | |||
|
|
|||
| class EitherTInstances<F, L>(val MF : Monad<F>) : EitherTMonadError<F, L> { | |||
| override fun MF(): Monad<F> = MF | |||
There was a problem hiding this comment.
This class requires a inline fun invoke constructor in the companion object that defaults the MF monad.
| override fun MF(): Monad<F> = MF | ||
| } | ||
|
|
||
| interface EitherTMonad<F, L> : Monad<EitherTF<F, L>> { |
There was a problem hiding this comment.
I'd rather we kept all instances together, yet still on a separate file. Open for discussing pros/cons.
| class KleisliInstances<F, D, E>(val FME: MonadError<F, E>) : KleisliMonadReader<F, D>, KleisliMonadError<F, D, E> { | ||
| override fun FM(): Monad<F> = FME | ||
|
|
||
| override fun FME(): MonadError<F, E> = FME |
| fun <A> fromEither(fab: Either<E, A>): HK<F, A> = | ||
| fab.fold({ raiseError<A>(it) }, { pure(it) }) | ||
|
|
||
| fun <A> catch(f: () -> A, recover: (Throwable) -> E): HK<F, A> = |
| fun <A> local(f: (D) -> D, fa: HK<F, A>): HK<F, A> | ||
|
|
||
| /** Retrieves a function of the environment */ | ||
| fun <A> reader(f: (D) -> A): HK<F, A> = map(ask(), f) |
There was a problem hiding this comment.
NIT: Formatting even for short methods is to have a new line after the =
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.