Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check all uses of Validated for deprecation #2994

Merged
merged 3 commits into from
Mar 29, 2023
Merged

Conversation

serras
Copy link
Member

@serras serras commented Mar 24, 2023

Fixes #2982

The uses were checked by runing grep --include=\*.kt -rnw . -e "Validated" in the arrow-libs folder, and then manually checking that each appearance was marked with @Deprecated.

No changes have been made to tests.

@serras serras requested review from nomisRev and a team March 24, 2023 15:23
@github-actions
Copy link
Contributor

github-actions bot commented Mar 24, 2023

Kover Report

File Coverage [56.44%]
arrow-libs/core/arrow-continuations/src/commonMain/kotlin/arrow/continuations/Reset.kt 100.00%
arrow-libs/core/arrow-continuations/src/commonMain/kotlin/arrow/continuations/generic/ControlThrowable.kt 100.00%
arrow-libs/core/arrow-continuations/src/jsMain/kotlin/arrow/continuations/generic/ControlThrowable.kt 100.00%
arrow-libs/core/arrow-continuations/src/jvmMain/kotlin/arrow/continuations/generic/ControlThrowable.kt 100.00%
arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/core/Either.kt 56.66%
arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/core/Sequence.kt 63.26%
arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/core/Validated.kt 50.00%
arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/core/computations/either.kt 50.00%
arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/core/continuations/EagerEffect.kt 38.46%
arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/core/continuations/EagerEffectScope.kt 56.52%
arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/core/continuations/Effect.kt 64.76%
arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/core/continuations/EffectScope.kt 64.52%
arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/core/raise/Effect.kt 66.67%
arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/core/raise/Mappers.kt 100.00%
arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/core/raise/RaiseAccumulate.kt 66.13%
arrow-libs/optics/arrow-optics/src/commonMain/kotlin/arrow/optics/Iso.kt 0.00%
Total Project Coverage 44.29%

Copy link
Collaborator

@gutiory gutiory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @serras!!

@serras serras merged commit faf27b1 into main Mar 29, 2023
@franciscodr franciscodr deleted the as-validated-deprecation branch April 21, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

["Request"] Review deprecations of Validated
3 participants