-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add error message to autofold #806
Conversation
@jereksel I tried adding some tests for the processor but ran into some issues. If I understand correctly I should.
Since Any ideas? Am I missing something? |
Codecov Report
@@ Coverage Diff @@
## master #806 +/- ##
============================================
- Coverage 44.71% 44.66% -0.06%
Complexity 623 623
============================================
Files 298 298
Lines 7657 7669 +12
Branches 831 832 +1
============================================
+ Hits 3424 3425 +1
- Misses 3930 3942 +12
+ Partials 303 302 -1
Continue to review full report at Codecov.
|
@nomisRev Try removing "build" directory in models. When you add new classes kapt often doesn't transform them. |
I think it's ok to throw exceptions since this should fail fast at compile time but I don't have an strong opinion since I'm actually more interested in removing the entire kapt API we use all together for something that wraps the Proto stuff which is tedious as hell to deal with. I'm also realizing that Maybe then we should consider merging these processors and annotations to be part of |
c099fa9
to
a664907
Compare
@jereksel I doubled checked everything but still get Test fail with following error I am unsure why it's trying to look in that location. Any ideas? |
@nomisRev That means that AP passed fine, but checking of output file failed (this directory is for AP output files). |
@jereksel I have no clue how to make it find the directory. The same thing is done for Optics. I'd like to close this PR, if we cannot fix tests I prefer to remove them for now. |
This closes #462
@JorgeCastilloPrz @raulraja As discussed in #766 I am not sure how we should proceed with throwing
KnownException
. I did a small spike with the scenario handled in this PR and had to rely onMonadError
andTraverse
for it to be somewhat manageable.