-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show constructor to use receiver type to enable object property access #835
Conversation
Codecov Report
@@ Coverage Diff @@
## master #835 +/- ##
=========================================
Coverage 44.41% 44.41%
Complexity 633 633
=========================================
Files 294 294
Lines 7459 7459
Branches 834 834
=========================================
Hits 3313 3313
Misses 3844 3844
Partials 302 302
Continue to review full report at Codecov.
|
Could you please use this chance to add a reference to the |
Good tip - I'll create a snippet |
This is a great chance to learn about Ank!! Ank is the tool we use to compile snippets. What is does is output the result of the last expression inside a block. With the changes you've introduced, as they're in the same block, they won't produce the snippet result. Compare the docs with the source: https://arrow-kt.io/docs/typeclasses/show/ The snippet will also fit better on the If you'd like to test Ank, use |
087f218
to
d5f59cc
Compare
…y access, Show and Eq doc examples
Show and Eq examples moved to Create your own instance locations(in separate anks). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's mergeeeeeeee 🎉
Thanks @ersin-ertan for the contribution! |
…y access, Show and Eq doc examples (arrow-kt#835)
Solves: #830