Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optics compiler warning & instance fixes #851

Merged
merged 6 commits into from
May 21, 2018
Merged

Conversation

nomisRev
Copy link
Member

  • Fix String Traversal instance
  • Solve compiler warnings for Optics

@codecov
Copy link

codecov bot commented May 21, 2018

Codecov Report

Merging #851 into master will increase coverage by 0.07%.
The diff coverage is 81.25%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #851      +/-   ##
============================================
+ Coverage     44.41%   44.49%   +0.07%     
  Complexity      633      633              
============================================
  Files           294      294              
  Lines          7459     7466       +7     
  Branches        834      834              
============================================
+ Hits           3313     3322       +9     
  Misses         3844     3844              
+ Partials        302      300       -2
Impacted Files Coverage Δ Complexity Δ
.../arrow-optics/src/main/kotlin/arrow/optics/Fold.kt 36.58% <0%> (ø) 0 <0> (ø) ⬇️
...s/src/main/kotlin/arrow/optics/instances/string.kt 100% <100%> (+53.84%) 0 <0> (ø) ⬇️
...rc/main/kotlin/arrow/optics/instances/sequencek.kt 57.14% <83.33%> (+11.68%) 0 <0> (ø) ⬇️
...main/kotlin/arrow/optics/instances/nonemptylist.kt 66.66% <83.33%> (+4.16%) 0 <0> (ø) ⬇️
...ain/kotlin/arrow/optics/typeclasses/FilterIndex.kt 18.18% <0%> (-54.55%) 0% <0%> (ø)
...tics/src/main/kotlin/arrow/optics/instances/map.kt 94.11% <0%> (+2.94%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 089cbed...b73e490. Read the comment docs.

@raulraja raulraja merged commit d2cb7a9 into master May 21, 2018
@raulraja raulraja deleted the simon-optics-small-fixes branch May 21, 2018 15:15
RawToast pushed a commit to RawToast/kategory that referenced this pull request Jul 18, 2018
* Fix Fold inline warning

* Fix NonEmptyList unchecked cast warning

* Fix SequenceK unchecked cast warning

* Fix String broken Traversal instance

* Detekt fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants