Add SingleK wrapper for RxJava Single #857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JorgeCastilloPrz
force-pushed
the
add-wrapper-for-rxjava-single
branch
from
9e446b5
to
3934e25
Compare
Codecov Report
@@ Coverage Diff @@
## master #857 +/- ##
============================================
+ Coverage 44.64% 44.86% +0.22%
- Complexity 623 628 +5
============================================
Files 298 300 +2
Lines 7669 7709 +40
Branches 832 834 +2
============================================
+ Hits 3424 3459 +35
- Misses 3942 3947 +5
Partials 303 303
Continue to review full report at Codecov.
|
pakoito
reviewed
May 24, 2018
| } | ||
| } | ||
|
|
||
| // FIXME(paco): remove if this hasn't triggered in a while - 26 Jan 18 |
There was a problem hiding this comment.
lol is this in both Observable and Flowable? I wouldn't have it on by default.
There was a problem hiding this comment.
Yeah was copypasta, removed now from the 3 wrappers, since it has not been triggered since January.
pakoito
reviewed
May 24, 2018
JorgeCastilloPrz
force-pushed
the
add-wrapper-for-rxjava-single
branch
from
7e3e849
to
dd92545
Compare
|
Back to you @pakoito |
pakoito
reviewed
May 25, 2018
| test.assertTerminated().assertComplete().assertNoErrors().assertValue(0) | ||
| } | ||
|
|
||
| "Multi-thread Observables should run on their required threads" { |
RawToast
pushed a commit
to RawToast/kategory
that referenced
this pull request
Jul 18, 2018
* add instances and law tests * generate complete info graph * remove shouldNotBe fallback to logs from ObservableK, FlowableK and SingleK tests * add SingleK to a couple of examples in docs, including Async based polymorphic program sample
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #856
SingleK