-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do a cleanup pass on Core #971
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff 👏
Codecov Report
@@ Coverage Diff @@
## master #971 +/- ##
=========================================
Coverage ? 46.66%
Complexity ? 660
=========================================
Files ? 308
Lines ? 8002
Branches ? 822
=========================================
Hits ? 3734
Misses ? 3939
Partials ? 329
Continue to review full report at Codecov.
|
As @trevorsummerssmith reported, the behavior of
map
andflatMap
for core constructs was inconsistent inside comprehensions. We'd like for both to be available, at least for the constructs in core.This PR addresses that to have a more consistent model for inlining: only transformations and getters are inlined.
A second fix removes unnecessary object creation from the implementation of operators. For this,
Try.Failure
now extendsTry<Nothing>