-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ktor
builder using Resource
#39
Conversation
8b186f7
to
a945ecb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM so far @gutiory
Is this not possible? 🤔 |
|
Hey @gutiory,
|
Good catch @nomisRev !. Thanks a lot for your analysis. |
@gutiory Arrow 1.1.5 is released, and the version bump has been merged into |
Co-authored-by: Simon Vergauwen <nomisRev@users.noreply.github.com>
Co-authored-by: Simon Vergauwen <nomisRev@users.noreply.github.com>
Co-authored-by: Simon Vergauwen <nomisRev@users.noreply.github.com>
Co-authored-by: Simon Vergauwen <nomisRev@users.noreply.github.com>
Co-authored-by: Simon Vergauwen <nomisRev@users.noreply.github.com>
`ktor-server-host-common` is the artefact to be used in a KMP, that provides `ApplocationEngine` to the project.
As the project is a KMP, `main` is not a valid `sourceSet`. The code must be placed under `commonMain`. The `Resource` acquire and release process is changed after last `Arrow` update. We use now the new `install` method.
8152bdf
to
db657d3
Compare
`Ktor` is published as hierarchical project structure, so we need to disable this feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥳 Thank you for an awesome first contribution @gutiory
This PR creates a function that allows to build a
Ktor
engine as aResource