Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require dateutil 2.8.2+ #1006

Merged
merged 2 commits into from
Jul 15, 2021
Merged

Require dateutil 2.8.2+ #1006

merged 2 commits into from
Jul 15, 2021

Conversation

jadchaar
Copy link
Member

Pull Request Checklist

Thank you for taking the time to improve Arrow! Before submitting your pull request, please check all appropriate boxes:

  • 🧪 Added tests for changed code.
  • 🛠️ All tests pass when run locally (run tox or make test to find out!).
  • 🧹 All linting checks pass when run locally (run tox -e lint or make lint to find out!).
  • 📚 Updated documentation for changed code.
  • ⏩ Code is up-to-date with the master branch.

If you have any questions about your code changes or any of the points above, please submit your questions along with the pull request and we will try our best to help!

Description of Changes

Bump dateutil to 2.8.2+ to update tz database.

We gotta figure out which open issues this closes.

@codecov
Copy link

codecov bot commented Jul 14, 2021

Codecov Report

Merging #1006 (6a50813) into master (c53113a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1006   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines         2146      2146           
  Branches       337       337           
=========================================
  Hits          2146      2146           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c53113a...6a50813. Read the comment docs.

Copy link
Member

@anishnya anishnya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anishnya anishnya merged commit 255f717 into master Jul 15, 2021
@pganssle
Copy link
Contributor

Why did you do this? Version 2.8.2 doesn't have any new features, there's no way that this library is compatible with 2.8.2 and not 2.8.0, at the very least.

Overly strict version specifications are a problem for the wider ecosystem, see, e.g. https://bernat.tech/posts/version-numbers/#version-conflicts. I think Hynek also gives some reasoning in this article.

@jadchaar jadchaar deleted the dateutil branch September 12, 2021 15:58
@jadchaar
Copy link
Member Author

Hey @pganssle, since this was the first patch to dateutil in 2 years, we thought it would be wise to require it as the bare minimum since it ships with the latest tz database. We thought locking it to 2.8.2+ would help reduce the amount of tz database bugs that get filed with arrow. Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants