Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to 1.2.3 and update CHANGELOG #1116

Merged
merged 1 commit into from
Jun 25, 2022

Conversation

systemcatch
Copy link
Collaborator

Pull Request Checklist

Thank you for taking the time to improve Arrow! Before submitting your pull request, please check all appropriate boxes:

  • 🧪 Added tests for changed code.
  • 🛠️ All tests pass when run locally (run tox or make test to find out!).
  • 🧹 All linting checks pass when run locally (run tox -e lint or make lint to find out!).
  • 📚 Updated documentation for changed code.
  • ⏩ Code is up-to-date with the master branch.

If you have any questions about your code changes or any of the points above, please submit your questions along with the pull request and we will try our best to help!

Description of Changes

@codecov
Copy link

codecov bot commented Jun 25, 2022

Codecov Report

Merging #1116 (fcc0630) into master (dc6428f) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master     #1116   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines         2325      2325           
  Branches       449       449           
=========================================
  Hits          2325      2325           
Impacted Files Coverage Δ
arrow/_version.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc6428f...fcc0630. Read the comment docs.

Copy link
Member

@jadchaar jadchaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Member

@krisfremen krisfremen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@anishnya anishnya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anishnya anishnya merged commit 8842f8c into arrow-py:master Jun 25, 2022
@systemcatch systemcatch deleted the changelog_123 branch June 29, 2022 09:43
@cyriaka90
Copy link
Contributor

Hello :) The newest version is still not available here: https://github.com/arrow-py/arrow/releases / https://pypi.org/project/arrow/#history
Is that on purpose?

@anishnya
Copy link
Member

@cyriaka90 no. Both I and @krisfremen don't have access to push tags to PyPi. We (hopefully) plan on pushing the tags out this week.

@cyriaka90
Copy link
Contributor

Ah, okay! Didn't know that.
Thanks - and no pressure! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants