Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for Python 3.11 #1126

Merged
merged 2 commits into from
Oct 4, 2022
Merged

Conversation

gruebel
Copy link
Contributor

@gruebel gruebel commented Oct 1, 2022

Pull Request Checklist

Thank you for taking the time to improve Arrow! Before submitting your pull request, please check all appropriate boxes:

  • 🧪 Added tests for changed code.
  • 🛠️ All tests pass when run locally (run tox or make test to find out!).
  • 🧹 All linting checks pass when run locally (run tox -e lint or make lint to find out!).
  • 📚 Updated documentation for changed code.
  • ⏩ Code is up-to-date with the master branch.

If you have any questions about your code changes or any of the points above, please submit your questions along with the pull request and we will try our best to help!

Description of Changes

Happy to get the chance to finally contribute something to this great project 🎉

  • Added support of Python 3.11. Was pretty easy, no deprecation warnings popped up, at least I didn't see them 😄
  • Added the Python 3.11 classifier

When Python 3.11 will be finally released, then the dev suffix for GHA should be removed.

@codecov
Copy link

codecov bot commented Oct 2, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (48520e7) compared to base (f8f3068).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #1126   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10         9    -1     
  Lines         2325      2318    -7     
  Branches       449       492   +43     
=========================================
- Hits          2325      2318    -7     
Impacted Files Coverage Δ
arrow/__init__.py

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gruebel
Copy link
Contributor Author

gruebel commented Oct 2, 2022

sorry, had to adjust the name of the version otherwise the tox-gh-actions plugin doesn't recognize it

Copy link
Member

@jadchaar jadchaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@krisfremen krisfremen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krisfremen krisfremen merged commit 1bba2a8 into arrow-py:master Oct 4, 2022
@gruebel gruebel deleted the add-python-311 branch October 4, 2022 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants