Move backports from extra_requires to install_requires #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jadchaar
changed the title
systemcatch
reviewed
Jul 29, 2019
setup.py
Outdated
| extras_require={":python_version=='2.7'": ["backports.functools_lru_cache>=1.2.1"]}, | ||
| install_requires=[ | ||
| "python-dateutil", | ||
| "backports.functools_lru_cache;python_version=='2.7'", |
There was a problem hiding this comment.
Is it ok that we've removed the >=1.2.1 requirement here? Now it could install an older version.
There was a problem hiding this comment.
I locked it to >=1.2.1 just in case :)
|
Ready for re-review @systemcatch. |
Codecov Report
@@ Coverage Diff @@
## master #620 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 8 8
Lines 1513 1513
Branches 228 228
=====================================
Hits 1513 1513Continue to review full report at Codecov.
|
systemcatch
approved these changes
Jul 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is now the official method for conditionally requiring python versions as documented here: https://setuptools.readthedocs.io/en/latest/setuptools.html#declaring-platform-specific-dependencies. Pytest does the same here: https://github.com/pytest-dev/pytest/blob/master/setup.py#L11.
Addresses: #495