Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve parsing of local strings with punctuation #720

Merged
merged 5 commits into from
Dec 3, 2019

Conversation

andrewchouman
Copy link
Contributor

This should fix #701. I decided to allow the punctuation: , . ; : ? ! " ' ` [ ] { } ( ) < >.

@systemcatch
Copy link
Collaborator

Hey @andrewchouman looks like the tests are failing due to black having some problems with parser.py and parser_tests.py.

@systemcatch systemcatch changed the title Local strings expansion bug Improve parsing of local strings with punctuation Nov 25, 2019
@codecov-io
Copy link

codecov-io commented Nov 25, 2019

Codecov Report

Merging #720 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #720   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           9      9           
  Lines        1583   1606   +23     
  Branches      262    266    +4     
=====================================
+ Hits         1583   1606   +23
Impacted Files Coverage Δ
arrow/parser.py 100% <100%> (ø) ⬆️
arrow/util.py 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32ad923...a8f34fc. Read the comment docs.

Copy link
Member

@jadchaar jadchaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid work, but I had a bit of feedback. Hopefully @systemcatch can chime in as well.

arrow/parser.py Outdated Show resolved Hide resolved
arrow/parser.py Outdated Show resolved Hide resolved
tests/parser_tests.py Show resolved Hide resolved
tests/parser_tests.py Show resolved Hide resolved
tests/parser_tests.py Show resolved Hide resolved
Copy link
Collaborator

@systemcatch systemcatch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments from me, overall this looks solid though.

arrow/parser.py Outdated Show resolved Hide resolved
docs/index.rst Show resolved Hide resolved
docs/index.rst Outdated Show resolved Hide resolved
@andrewchouman
Copy link
Contributor Author

Requested Regex101. Let me know if this isn't enough
Regular Date
Before Epoch
YYYYMM

@andrewchouman
Copy link
Contributor Author

Do the changes look good? @jadchaar @systemcatch

Copy link
Collaborator

@systemcatch systemcatch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrewchouman All good on my end, let's see if Jad has anything else to add.

Copy link
Member

@jadchaar jadchaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the hard work @andrewchouman !

@jadchaar jadchaar merged commit 5d0830e into arrow-py:master Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Locale strings not expanded in get format
4 participants