-
-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve parsing of local strings with punctuation #720
Improve parsing of local strings with punctuation #720
Conversation
Hey @andrewchouman looks like the tests are failing due to |
Codecov Report
@@ Coverage Diff @@
## master #720 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 9 9
Lines 1583 1606 +23
Branches 262 266 +4
=====================================
+ Hits 1583 1606 +23
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solid work, but I had a bit of feedback. Hopefully @systemcatch can chime in as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few comments from me, overall this looks solid though.
Requested Regex101. Let me know if this isn't enough |
Do the changes look good? @jadchaar @systemcatch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andrewchouman All good on my end, let's see if Jad has anything else to add.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the hard work @andrewchouman !
This should fix #701. I decided to allow the punctuation:
, . ; : ? ! " ' ` [ ] { } ( ) < >
.