Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EC-18893] expired code can remove by clicking on remove button #4

Merged
merged 1 commit into from
Feb 3, 2020

Conversation

unnati-bhavsar
Copy link
Contributor

@unnati-bhavsar unnati-bhavsar commented Jan 20, 2020

What's this PR do?

  • Expired codes shows as disabled and remove button to remove expired code

Where should the reviewer start?

  • NA

How should this be manually tested?

  • Verify at Rewards page, expired codes are disabled and remove button to remove expired code block

Any background context you want to provide?
-NA

What are the relevant tickets?

@unnati-bhavsar
Copy link
Contributor Author

@karan-darji
PR for in-active the expired code from rewards page by click on remove button

@shabbir-lightwala
Copy link

I have verified this PR at the local server and it's working fine.

@@ -17,4 +17,9 @@ class Reward extends ApiResource
use ApiOperations\Retrieve;
use ApiOperations\Update;

public function removeExpiredCode($reward_id) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this as it's not needed

@karan-darji karan-darji merged commit 46e2454 into master Feb 3, 2020
@karan-darji karan-darji deleted the feature/expired-eci-codes branch February 3, 2020 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants