-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stops working with JQuery 1.9 and 2.0 #26
Comments
Had the same issue using it on Android - thanks for pointing it out! |
This is what I found out. Not sure if this is the reason or not. If it is I question the reason for removing it from jQuery 1.9. "Note: This method signature was deprecated in jQuery 1.8 and removed in jQuery 1.9. jQuery also provides an animation method named .toggle() that toggles the visibility of elements. Whether the animation or the event method is fired depends on the set of arguments passed." |
Confirming that as well. |
I can confirm that this issue exists with jQuery 1.10.2 and that @MaddinXx 's solution does make sidr work with jQuery 1.10.2. I have posted a minified version of Sidr with the fix at: https://gist.github.com/Shelob9/6085459 |
Fixes #26 (second time open in some browsers)
Dear All,
I'm testing this lib and loves it, but I experienced the following: with JQuery 1.7 it works great but replacing with jQuery 1.9.1 or the today released 2.0.0, after one opening and closing action, the menu never opens again no matter how I press the link for it.
Did anyone else experienced the same? Does anyone have a solution for it?
The text was updated successfully, but these errors were encountered: