Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stops working with JQuery 1.9 and 2.0 #26

Closed
imrefazekas opened this issue Apr 19, 2013 · 4 comments
Closed

Stops working with JQuery 1.9 and 2.0 #26

imrefazekas opened this issue Apr 19, 2013 · 4 comments

Comments

@imrefazekas
Copy link

Dear All,

I'm testing this lib and loves it, but I experienced the following: with JQuery 1.7 it works great but replacing with jQuery 1.9.1 or the today released 2.0.0, after one opening and closing action, the menu never opens again no matter how I press the link for it.

Did anyone else experienced the same? Does anyone have a solution for it?

@kingtom
Copy link

kingtom commented May 15, 2013

Had the same issue using it on Android - thanks for pointing it out!

@Monkey76
Copy link

Monkey76 commented Jun 2, 2013

This is what I found out. Not sure if this is the reason or not. If it is I question the reason for removing it from jQuery 1.9.

"Note: This method signature was deprecated in jQuery 1.8 and removed in jQuery 1.9. jQuery also provides an animation method named .toggle() that toggles the visibility of elements. Whether the animation or the event method is fired depends on the set of arguments passed."

Source: http://api.jquery.com/toggle-event/

@michelkaeser
Copy link
Contributor

Confirming that as well.

@Shelob9
Copy link

Shelob9 commented Jul 26, 2013

I can confirm that this issue exists with jQuery 1.10.2 and that @MaddinXx 's solution does make sidr work with jQuery 1.10.2.

I have posted a minified version of Sidr with the fix at: https://gist.github.com/Shelob9/6085459

artberri added a commit that referenced this issue Nov 5, 2013
Fixes #26 (second time open in some browsers)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants