Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust server tolerance to frequent keepalive pings #451

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

sevein
Copy link
Member

@sevein sevein commented Feb 12, 2024

This avoids the following error seen in some clients while processing big transfers:

ipv4:127.0.0.1:42625: Received a GOAWAY with error code ENHANCE_YOUR_CALM and debug data equal to "too_many_pings". Current keepalive time (before throttling): ∞

@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (7821c59) 45.85% compared to head (6254dd4) 45.85%.

Files Patch % Lines
a3m/server/runner.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #451   +/-   ##
=======================================
  Coverage   45.85%   45.85%           
=======================================
  Files         106      106           
  Lines        7413     7413           
  Branches     1202     1202           
=======================================
  Hits         3399     3399           
  Misses       3842     3842           
  Partials      172      172           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sevein sevein merged commit 29e83ec into main Feb 12, 2024
6 checks passed
@sevein sevein deleted the dev/enhance-your-calm branch February 12, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants