Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: CI does not check if migrations are consistent #797

Closed
jhsimpson opened this issue Nov 16, 2017 · 3 comments
Closed

Problem: CI does not check if migrations are consistent #797

jhsimpson opened this issue Nov 16, 2017 · 3 comments
Labels
Type: enhancement An improvement to existing functionality.

Comments

@jhsimpson
Copy link
Member

Sometimes new Pull Reqests add code that requires a django migration to be run. It would be very helpful to add a travis check for this to all PR's.

This tool might do the job:
https://github.com/rev112/django-migration-checker
@jhsimpson jhsimpson mentioned this issue Nov 16, 2017
Closed
@sevein
Copy link
Member

sevein commented Nov 16, 2017 •
edited
Loading

I did something similar in fpr-admin, here: https://github.com/artefactual/archivematica-fpr-admin/blob/677607a38ed6d18bd8fa1601e1704a4096e30afe/.travis.yml#L7-L15.

@sevein sevein added this to the 1.8.0 milestone Dec 4, 2017
@sromkey sromkey removed this from the 1.8.0 milestone Aug 3, 2018
@sevein
Copy link
Member

sevein commented Feb 28, 2019

We have this working in SS: artefactual/archivematica-storage-service@b19aaa3#diff-1a8bb89e4b6a6d450e4dab3b70074e80.

It could be added to the AM repo too.

@sevein sevein changed the title Enhancement: automatic check for django migrations Problem: CI does not check if migrations are consistent Feb 28, 2019
@sevein sevein added triage-release-1.10 Type: enhancement An improvement to existing functionality. labels Feb 28, 2019
@sevein sevein added the Status: ready The issue is sufficiently described/scoped to be picked up by a developer. Waffle label. label Mar 13, 2019
@sevein sevein mentioned this issue Dec 2, 2020
Merged
@sevein sevein removed the Status: ready The issue is sufficiently described/scoped to be picked up by a developer. Waffle label. label Dec 2, 2020
@sevein
Copy link
Member

sevein commented Dec 2, 2020

Also in AM, added in #1639.

@sevein sevein closed this as completed Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: enhancement An improvement to existing functionality.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sevein @jhsimpson @sromkey