Problem: Non-equivalent directory name comparison in Transfers.py #61
Comments
qubot
pushed a commit
that referenced
this issue
May 10, 2018
This PR adds capability to AM Client in support of the API functions required for automated reingest. * Adds new functions to AM Client, including reingest and transfer status. * Adds a new feature to list compressed AIPS. * Makes the new functions available to the client executable. * Provides unit testing for the additional function calls. * Extends utils.py request mechanism to enable http authentication headers to be set. * A formatting issue was discovered in models.py while testing which is now corrected. * Warning for non-JSON responses are only output if there is a non-OK HTTP response where responses from the API are not always JSON. * Refactors transfer.py approve_transfers. * Introduces a unit test for approve transfers to enable refactor. * Rewrites approve_transfers to match previous returns. * Rewrites approve_transfers to use AM Client module. * Fixes #60 * Fixes #61 * Fixes #64 * Resolves #67 * Additional testing to help capture symptoms of #62
qubot
pushed a commit
that referenced
this issue
May 10, 2018
This PR adds capability to AM Client in support of the API functions required for automated reingest. * Adds new functions to AM Client, including reingest and transfer status. * Adds a new feature to list compressed AIPS. * Makes the new functions available to the client executable. * Provides unit testing for the additional function calls. * Extends utils.py request mechanism to enable http authentication headers to be set. * A formatting issue was discovered in models.py while testing which is now corrected. * Warning for non-JSON responses are only output if there is a non-OK HTTP response where responses from the API are not always JSON. * Refactors transfer.py approve_transfers. * Introduces a unit test for approve transfers to enable refactor. * Rewrites approve_transfers to match previous returns. * Rewrites approve_transfers to use AM Client module. * Fixes #60 * Fixes #61 * Fixes #64 * Resolves #67 * Additional testing to help capture symptoms of #62
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
See: https://github.com/artefactual/automation-tools/blob/master/transfers/transfer.py#L373
We're comparing a string that comes into the function with an fsencoded (byte) string, which will result in a match not being found in Python3.
Plain and encoded strings look like as follows:
The text was updated successfully, but these errors were encountered: