Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pb atom-trusty: remove percona-client role #78

Merged
merged 1 commit into from
May 12, 2018
Merged

pb atom-trusty: remove percona-client role #78

merged 1 commit into from
May 12, 2018

Conversation

hakamine
Copy link
Member

This is not required as percona role installs both server and client. It was also
causing issues as this role is not updated and was preventing the
server to start.

Fixes #74

This was referenced May 11, 2018
Closed
Closed
jraddaoui
jraddaoui requested changes May 12, 2018
View reviewed changes
Copy link
Contributor

@jraddaoui jraddaoui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hakamine!

I think we should do the same in 'atom-xenial'. And I'd remove it completely instead of leaving it as comments.

@hakamine @jraddaoui
pb atom-trusty: remove percona-client role
236cec6 
This is not required as percona role installs the client. It was also
causing issues as this role is not updated and was preventing the
server to start.
@qubot qubot force-pushed the dev/issue-gh-74-atom-trusty-percona branch from 349ecb5 to 236cec6 Compare May 12, 2018 19:49
jraddaoui
jraddaoui approved these changes May 12, 2018
View reviewed changes
Copy link
Contributor

@jraddaoui jraddaoui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like in Xenial is only referenced in the requirements, so I've only amended your commit to remove the comments and the requirement.

Thanks again @hakamine!

@qubot qubot merged commit 236cec6 into master May 12, 2018
@qubot qubot deleted the dev/issue-gh-74-atom-trusty-percona branch May 12, 2018 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jraddaoui jraddaoui jraddaoui approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hakamine @jraddaoui @qubot