Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to compile the templated EmailMessage object into standard EmailMessage #8

Closed
artemrizhov opened this issue Nov 28, 2014 · 8 comments

Comments

@artemrizhov
Copy link
Owner

send_mail function should compile messages by default. This should fix the serialization problem described in #7.

@artemrizhov
Copy link
Owner Author

This also may be implemented by providing property getters for body, subject, etc.

@jonashaag
Copy link

This also may be implemented by providing property getters for body, subject, etc.

True, but that solution would still miss the "evaluate templates NOW" feature.

@ptwobrussell
Copy link

FWIW, I think I just got bitten by this when trying to use this package in combination with djcelery-email because the messages don't compile by default and a pickling error erupts. Serializing to avoid that would be quite helpful.

@jonashaag
Copy link

You might want to try my reimplementation https://github.com/jonashaag/django-mail-templated-simple

@ptwobrussell
Copy link

Looks great, thanks!

On Sun, Feb 15, 2015 at 7:36 PM, Jonas Haag notifications@github.com
wrote:

You might want to try my reimplementation
https://github.com/jonashaag/django-mail-templated-simple


Reply to this email directly or view it on GitHub
#8 (comment)
.

@jonashaag
Copy link

Sorry for resurrecting this old issue. It just wanted to let @ptwobrussell know that django-mail-templated-simple is now a properly tested and installable project.

@ptwobrussell
Copy link

Thanks!

On Fri, Nov 20, 2015 at 9:21 AM, Jonas Haag notifications@github.com
wrote:

Sorry for resurrecting this old issue. It just wanted to let @ptwobrussell
https://github.com/ptwobrussell know that django-mail-templated-simple
is now a properly tested and installable project.


Reply to this email directly or view it on GitHub
#8 (comment)
.

@artemrizhov
Copy link
Owner Author

@jonashaag @ptwobrussell
Just letting you know that the latest version should not have any issues with serialization. It also supports the template inheritance as is. The app is much more stable now. All features will be described in the documentation that I will publish soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants