Add no_pretty renderer option to chat command #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablorc
reviewed
May 18, 2023
| module Jambots::Renderers | ||
| class CliRenderer | ||
| def render(conversation, &block) | ||
| spinner.auto_spin |
There was a problem hiding this comment.
I think the spinner should be put in the Thor file, and these renderers are like Rails views, where everything is computed and they just render the final response.
Just an idea
There was a problem hiding this comment.
I have some doubts about it. Could we have problems if we have a spinner and create a not-pretty output to send it in a pipeline like in the following example?
$ jambots chat "hello" --no-pretty > hello.txt
There was a problem hiding this comment.
What happens right now when you do this? I did that in the Kevin/Bob experiment and I didn't see any spinners. I suppose they buffer play TTY does avoids weird behaviors when redirecting the output.
If this is covered it should be OK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #5