Add support for cdot and times LaTeX commands #6
Conversation
|
Why are What's the use case here? |
|
Apologies, I read through the code to get a better understanding and made an incorrect assumption I should use the localFunctions pattern to add support for these instead of the lexer (since they're infix ops as you mention). I made the changes you mention, updated my tests and all are passing. The use case is to support MathQuill syntax, which here is an example on their doc website.
|
| @@ -9,6 +9,7 @@ | |||
| "private": false, | |||
| "scripts": { | |||
| "build": "babel -d dist src && webpack dist/minifier.js -o dist/evaluatex.min.js", | |||
| "postinstall": "npm run build", | |||
There was a problem hiding this comment.
Why the postinstall? The NPM package ships with Babel and minified ES sources. We don't want end users of the library to build it on every install.
| // `b` isn't bound | ||
| test("{a}\\cdot{b}", undefined, { a: 2 }, {}, { latex: true }); | ||
| } catch(err) { | ||
| assert.equal(true, err instanceof Error); |
There was a problem hiding this comment.
This assertion should also check that the error message is correct and helpful, otherwise it passes on any error.
Chai also has an instanceOf assertion that would be more semantic here.
| // `a` is a string | ||
| test("{a}\\cdot{b}", 4, { a: '2', b: 2 }, {}, { latex: true }); | ||
| } catch(err) { | ||
| assert.equal(true, err instanceof Error); |
|
Any chance you merge this? |
Merged and published version |
Fixes the
timesproblem mentioned in #1, but could probably as you mention add a thorough test suite for LaTeX commands in the future. For my use case I at least need support forcdotandtimes. All other iterations I've tried for my needs work otherwise though.