Various improvements mostly related to Docker usage #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Main program: - Handle SIGINT/SITGERM better (explicitly terminate openconnect). Without this, stopping the Docker container wouldn't allow openconnect to restore /etc/resolv.conf. - Allow one-time code to be specified in conf file/environment Docker wrapper scripts: - Use environment to pass one-time code (old approach of overriding the secret value in conf file didn't work) - Identify whether code is needed more generically (if ANY totp.xxxx secrets are specified, skip the code) - Skip commented lines in conf file when looking for secrets, username, etc. - Output appropriate Docker logfiles when stopping and starting - Add stop-docker.sh script to cleanly bring down VPN, with logs Docker image: - Use python 3, based on python/debian-slim base image - Multi-stage build to keep openconnect build tools out of final image - Only gp-okta.conf needs to be mounted into image now - Update URL for retrieving vpnc-script (old git repository has gone away) - Disable buffering for cleaner output
|
@arthepsy do you have any questions or comments about this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main program:
Without this, stopping the Docker container wouldn't allow
openconnect to restore /etc/resolv.conf.
Docker wrapper scripts:
the secret value in conf file didn't work)
secrets are specified, skip the code)
etc.
Docker image:
gone away)