remove .decode('utf-8') for python3 support #15
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR intended to fix this issue #14
As mentioned by @Rogdham, I think that we should removed
.decode('utf-8')
because "Begin with Python 3, all string is unicode object.", based recommendation from answer for this question and answer for this question, it should be removed.note:
I've tested running the test
py.test --cov-report= --cov=ssh-audit -v test
andpython3 -m py.test --cov-report= --cov=ssh-audit -v test
for python3 and have no error.But, double check should be done because I don't know what the reason behind of using
.decode('utf-8')
, maybe it to avoid strange behavior for special case (?).