Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #90. Fix Wkt scope problem and adds arcgis working samples. #155

Merged
merged 1 commit into from
Sep 3, 2021

Conversation

cancastilho
Copy link
Contributor

@cancastilho cancastilho commented Aug 22, 2021

To solve 'multiple define errors' when using this library with arcgis, Wkt variable must be set as global scope.

This pull request adds working samples for arcgis javascript api version 3.x and 4.x. To see them working, you should start a http-server from the project root path and open the url as following:

http://localhost:8080/doc/arcgis3.html

or

http://localhost:8080/doc/arcgis4.html

I recommend deleting the old arcgis.html sample, since it's not working.

@arthur-e arthur-e merged commit d9fb3e2 into arthur-e:master Sep 3, 2021
@arthur-e
Copy link
Owner

arthur-e commented Sep 3, 2021

This is great! Thanks.

@arthur-e
Copy link
Owner

arthur-e commented Sep 3, 2021

Just want to add a link indicating this fixes #90.

@arthur-e
Copy link
Owner

arthur-e commented Sep 3, 2021

This does indeed fix the demos in the doc/ folder, if someone sets up a local HTTP server. However, I am struggling with how to fix the demos on the gh-pages branch. These are the ones that people actually see (i.e., on the public web) and are referenced in #90 and #152.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants