replace global esri deps with AMD #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
but... you still need to have a mapping to |
|
We don't have any tests written for the ESRI integration. Can anyone confirm whether or not this pull request is backwards compatible? Thanks! |
|
@amenadiel the js api is on bower and dojo provides an amd loader in the global scope. If you are using dojo or the esri api, which is built on top of dojo, then you already have a loader ( |
|
hi, this works very well with ESRI 4.1, I'll use the commit until a new release is cut. |
|
Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #74
in case you don't want to choose one or the other.