-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This PR Implements E-CF handling and fixes an attribute error #248
Conversation
Hi @andrp92 , Thanks for the contribution, sorry I didn't pick it up sooner. Can you provide some more background for this change? The change extends the lookup function but doesn't change the validation. Can you add a quick note on the extra parameters that were introduced? They only seem to be used for an NCF that starts with an E (is it E-CF or e-NCF?). Can you also provide translations for the other returned values? Can you provide a test number or invocation to demonstrate this? Thanks. |
Hi @arthurdejong, This change allows stdnum to evaluate not only normal fiscal sequence (NCF) but also electronic ones (E-NCF). E-CF validation is already being performed here https://github.com/arthurdejong/python-stdnum/blob/master/stdnum/do/ncf.py#L84 Both terms are correct since they refer to two different stuff (it's confusing, right? jeje). E-CF is the named they adopted for this new way of issuing electronic invoices. E-NCF is the number with the electronic format. The extra parameters that were introduced are required when entering E-NCF on the page In regards of the translation, thanks for the observations, I will definitely add them. You can use these for demonstration: If you have any other questions, please let me know and again, thanks a lot for the feedbacks. |
@arthurdejong something else i've realized, I see travis is yelling at me with some flake8 error. Is it something I'm doing wrong on my end?
|
I would prefer to Hi @andrp92 , The flake8 errors can be found here: https://travis-ci.com/github/arthurdejong/python-stdnum/jobs/473198524 Most of them are related to trailing white space at the end of the line that shouldn't be there. Another thing is that the variable names should probably be Anyway, those are all pretty simple fixes I can make before merging. The most important bits are
|
@arthurdejong Hello, sorry for the late response. I'm confused about the translation process. Based on the documentations, response will be on Spanish, should we add translation from Spanish to english? Regards the test data, you can use the info bellow: RNC : 131793916 |
It seems that the numbers provided do not validate on https://dgii.gov.do/app/WebApps/ConsultasWeb2/ConsultasWeb/consultas/ncf.aspx Regarding the translation: the normal NCF lookup returns a dict with keys name, status, type, rnc, etc. I would like to have the same (or equivalent) keys for the E-NCF. I would like translations for
Thanks |
Hi @arthurdejong, I'm part of the same team as @andrp92 and have been tasked with working with this fork. Sorry for the late response. Here is some test data that you can use to test if functionality works as expected: ENCF NCF If there are any more issues to fix, please do let me know. |
Hey @arthurdejong , I know it's been a while. Please check the latest changes submitted by @frankroberto20 and let us know if there's anything else we need to do to get this merged. Thanks.! |
@arthurdejong sorry for insisting with this one. We just have an app crashing right know 😅 |
Hello @arthurdejong , please check this out whenever you can. |
No description provided.