Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datepicker): enable showToday prop to be provided on TypeScript #306

Merged
merged 5 commits into from
Jun 29, 2020

Conversation

arthurdenner
Copy link
Owner

What kind of change does this PR introduce?
Bugfix. Closes #302.

What is the current behavior?
The showToday prop is not listed in the TS types.

What is the new behavior?
The prop is listed and an example of its usage was added to the docs.

Checklist:

  • Documentation
  • Tests
  • Ready to be merged

@arthurdenner arthurdenner added the bug Something isn't working label Jun 29, 2020
@vercel
Copy link

vercel bot commented Jun 29, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/arthurdenner/react-semantic-ui-datepickers/lzgwee07v
✅ Preview: https://react-semantic-ui-datepickers-git-fix-enable-showtoday-prop.arthurdenner.vercel.app

@codecov
Copy link

codecov bot commented Jun 29, 2020

Codecov Report

Merging #306 into develop will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #306      +/-   ##
===========================================
- Coverage    87.84%   87.78%   -0.06%     
===========================================
  Files           15       15              
  Lines          477      475       -2     
  Branches        94       94              
===========================================
- Hits           419      417       -2     
  Misses          56       56              
  Partials         2        2              
Impacted Files Coverage Δ
src/components/calendar/calendar.tsx 100.00% <ø> (ø)
src/components/icon.tsx 100.00% <ø> (ø)
src/index.tsx 90.67% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0e1073...2ba07ce. Read the comment docs.

@arthurdenner arthurdenner merged commit 0a65959 into develop Jun 29, 2020
@arthurdenner arthurdenner deleted the fix/enable-showToday-prop branch June 29, 2020 13:43
@arthurdenner
Copy link
Owner Author

🎉 This PR is included in version 2.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Way to remove Today button from picker?
1 participant