Skip to content

fix(datepicker): pass required prop to Form.Field #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 24, 2020

Conversation

arthurdenner
Copy link
Owner

What kind of change does this PR introduce?
Bug fix. Closes #374.

What is the current behavior?
When an input is required, the label isn't styled properly.

What is the new behavior?
The label is styled properly.

Checklist:

  • Documentation
  • Tests
  • Ready to be merged

@arthurdenner arthurdenner added the bug Something isn't working label Aug 24, 2020
@vercel
Copy link

vercel bot commented Aug 24, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/arthurdenner/react-semantic-ui-datepickers/hwq3eby1e
✅ Preview: https://react-semantic-ui-datepickers-git-fix-required-input-style.arthurdenner.vercel.app

@codecov
Copy link

codecov bot commented Aug 24, 2020

Codecov Report

Merging #375 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #375   +/-   ##
========================================
  Coverage    88.75%   88.75%           
========================================
  Files           16       16           
  Lines          489      489           
  Branches        97       97           
========================================
  Hits           434      434           
  Misses          53       53           
  Partials         2        2           
Impacted Files Coverage Δ
src/components/input.tsx 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77f0ef8...13654d0. Read the comment docs.

@arthurdenner arthurdenner merged commit cd037e3 into develop Aug 24, 2020
@arthurdenner arthurdenner deleted the fix/required-input-style branch August 24, 2020 22:17
@arthurdenner
Copy link
Owner Author

🎉 This PR is included in version 2.9.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to see *required star on the label
1 participant