Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

integration-tests.yml:32-37: Fix integration tests and... #977

Closed
0pdd opened this issue Dec 15, 2021 · 3 comments · Fixed by #989
Closed

integration-tests.yml:32-37: Fix integration tests and... #977

0pdd opened this issue Dec 15, 2021 · 3 comments · Fixed by #989
Assignees
@baudoliver7
Labels
help wanted Extra attention is needed

Comments

@0pdd
Copy link

0pdd commented Dec 15, 2021

The puzzle 855-2061b0aa from #855 has to be resolved:

artipie/.github/workflows/integration-tests.yml

Lines 32 to 37 in 90c304b

# @todo #855:30min Fix integration tests and remove `@Disabled` annotation.
# These tests were not migrated to testcontainers, fix them one by one:
# src/test/java/com/artipie/VertxMainITCase.java
# src/test/java/com/artipie/docker/DockerProxyIT.java
# src/test/java/com/artipie/docker/DockerOnPortIT.java
# src/test/java/com/artipie/maven/MavenMultiProxyIT.java

The puzzle was created by Evgeny Chugunnyy (John) on 10-Dec-21.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
0pdd referenced this issue Dec 15, 2021
@g4s8
todo: fix puzzle format
90c304b
This was referenced Dec 15, 2021
Closed
Closed
@g4s8 g4s8 added the help wanted Extra attention is needed label Jan 20, 2022
baudoliver7 added a commit to baudoliver7/artipie that referenced this issue Jan 21, 2022
@baudoliver7
test: fix VertxMainITCase
3588111 
Test `startsWhenNotValidRepoConfigsArePresent` was failing because of
exception when `RepoConfig` was invalid. To fix it, we used a default
one.

Fix: artipie#977
@baudoliver7 baudoliver7 mentioned this issue Jan 21, 2022
Merged
baudoliver7 added a commit to baudoliver7/artipie that referenced this issue Jan 29, 2022
@baudoliver7
refactor: revert changes on RepoConfig
787ad4a 
Ref: artipie#977
baudoliver7 added a commit to baudoliver7/artipie that referenced this issue Jan 29, 2022
@baudoliver7
test: add ressource file for invalid repo config
c3279f8 
Ref: artipie#977
baudoliver7 added a commit to baudoliver7/artipie that referenced this issue Jan 29, 2022
@baudoliver7
test(VertxMainITCase): migrate tests to testcontainers
ef8f92d 
Ref: artipie#977
baudoliver7 added a commit to baudoliver7/artipie that referenced this issue Jan 29, 2022
@baudoliver7
test(VertxMainITCase): migrate tests to testcontainers
decc119 
Ref: artipie#977
baudoliver7 added a commit to baudoliver7/artipie that referenced this issue Jan 29, 2022
@baudoliver7
test(VertxMainITCase): migrate tests to testcontainers
9467197 
Ref: artipie#977
baudoliver7 added a commit to baudoliver7/artipie that referenced this issue Jan 29, 2022
@baudoliver7
test(VertxMainITCase): migrate tests to testcontainers
03def6e 
Ref: artipie#977
baudoliver7 added a commit to baudoliver7/artipie that referenced this issue Jan 29, 2022
@baudoliver7
test(VertxMainITCase): migrate tests to testcontainers
4009fb2 
Ref: artipie#977
baudoliver7 added a commit to baudoliver7/artipie that referenced this issue Jan 29, 2022
@baudoliver7
test(VertxMainITCase): migrate tests to testcontainers
1e23873 
Ref: artipie#977
baudoliver7 added a commit to baudoliver7/artipie that referenced this issue Feb 1, 2022
@baudoliver7
test: fix startsWhenNotValidRepoConfigsArePresent
0906814 
Ref: artipie#977
baudoliver7 added a commit to baudoliver7/artipie that referenced this issue Feb 2, 2022
@baudoliver7
test: diseable RpmITCase
ad85db8 
Ref: artipie#977
@g4s8 g4s8 closed this as completed in #989 Feb 3, 2022
0pdd referenced this issue Feb 4, 2022
@baudoliver7
fix(pdd): exclude some doc files (#994)
5dd565f 
We noticed that sometimes we can use the keyword `@todo` in `CHANGELOG.md`, `CODE_OF_CONDUCT.md`,
`CONTRIBUTING.md` without it being a puzzle. But `pdd` will fail on that saying that it doesn't
match to puzzle format.
We decided to exclude them all from pdd checking.

Cc: (commit)[b281fbd#commitcomment-65919004]
@0pdd 0pdd mentioned this issue Feb 4, 2022
Closed
@0pdd
Copy link
Author

0pdd commented Feb 4, 2022

@0pdd the puzzle #996 is still not solved.

@0pdd
Copy link
Author

0pdd commented Feb 16, 2022

@0pdd the puzzle #1013 is still not solved; solved: #996.

@0pdd
Copy link
Author

0pdd commented Feb 17, 2022

@0pdd all 2 puzzles are solved here: #1013, #996.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@baudoliver7 baudoliver7

Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: fix VertxMainITCase baudoliver7/artipie
3 participants
@g4s8 @baudoliver7 @0pdd