Remove console.log('fit') #347
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed unnecessarily console.log for production usage.
|
No need. When you |
|
Ok, but the .min,js version still contains it. (search for console.log in https://cdnjs.cloudflare.com/ajax/libs/fotorama/4.6.3/fotorama.min.js) |
Closed
|
I'm seeing this as well. |
|
Could it be that the minified file (fotorama.min.js) hosted by cloudflare was manually minified based on the official release¹, which is not minified (#361) and has this console.log not commented? |
|
It is still present in fotorama-bower. |
Rikk
added a commit
to Rikk/fotorama-bower
that referenced
this pull request
Feb 9, 2015
Rikk
added a commit
to Rikk/fotorama
that referenced
this pull request
Feb 9, 2015
Rikk
added a commit
to Rikk/fotorama
that referenced
this pull request
Feb 9, 2015
Rikk
added a commit
to Rikk/fotorama
that referenced
this pull request
Mar 9, 2015
|
Thank you. When can we expect a new release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed unnecessarily console.log for production usage.