Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add a test for unsubscribing a topic with a routing key #238

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

narikazu
Copy link
Member

No description provided.

@artsy-peril
Copy link
Contributor

artsy-peril bot commented Nov 25, 2021

Fails
🚫

Danger failed to run peril-downloaded-artsy/peril-settings@org/jira/pr.ts.

🚫

Danger failed to run peril-downloaded-artsy/peril-settings@org/allPRs.ts.

🚫 Please add a description to your PR.
Warnings
⚠️ Please assign someone to merge this PR, and optionally include people who should review.

Error TypeError

Cannot convert undefined or null to object
TypeError: Cannot convert undefined or null to object
    at Function.from (<anonymous>)
    at reverse (peril-downloaded-artsy/peril-settings@/org/jira/utils.ts:39:32)
    at exports.getJiraTicketIDsFromText (peril-downloaded-artsy/peril-settings@/org/jira/utils.ts:10:25)
    at Object.exports.default (peril-downloaded-artsy/peril-settings@org/jira/pr.ts:15:30)
    at processTicksAndRejections (internal/process/task_queues.js:97:5)

Dangerfile

34|   // We know we have something to work with now
35|   const jira: JiraApi.default = new (JiraApi as any)({
36|     protocol: "https",
37|     host: `${companyPrefix}.atlassian.net`,
38|     apiVersion: "2",
----------------------------------^
39|     strictSSL: true,
40|     username: peril.env.JIRA_EMAIL,
41|     password: peril.env.JIRA_ACCESS_TOKEN,
42|   })

Error TypeError

Cannot read property 'includes' of null
TypeError: Cannot read property 'includes' of null
    at Object.exports.rfc16 (peril-downloaded-artsy/peril-settings@org/allPRs.ts:68:17)
    at Object.exports.default (peril-downloaded-artsy/peril-settings@org/allPRs.ts:196:19)
    at processTicksAndRejections (internal/process/task_queues.js:97:5)

Dangerfile

63|   }
64| }
65| 
66| // Require changelog entries on PRs with code changes
67| // https://github.com/artsy/peril-settings/issues/16
-------------------^
68| export const rfc16 = async () => {
69|   const pr = danger.github.pr
70| 
71|   if (pr.base.repo.name === "eigen") {

Generated by 🚫 dangerJS against fd44cc0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant