Allow user to log into staging and get a new token #FF #8
Conversation
| @@ -6,10 +6,30 @@ class Gravity { | |||
| production: "api.artsy.net", | |||
| } | |||
|
|
|||
| async getAccessToken(credentials: Credentials) { | |||
| const gravityUrl = this.url("oauth2/access_token") | |||
There was a problem hiding this comment.
@joeyAghion this seems like a reasonable way to authenticate, but let me know if there is a method that makes more sense.
There was a problem hiding this comment.
I'd have to dig... is this where Force posts credentials to obtain an access token today?
There was a problem hiding this comment.
I think it is. And I imagine this cli is not tight to Force, as long as it's a valid access token generated by Gravity?
There was a problem hiding this comment.
Correct - any valid id/secret will do.
| async get(endpoint: string) { | ||
| const token: string = process.env.TOKEN! // temp until our auth/token plumbing is hooked up | ||
|
|
||
| const gravityUrl: string = this.url(endpoint) | ||
| const gravityUrl: string = this.url(`api/v1/${endpoint}`) |
There was a problem hiding this comment.
I had to do a little bit of shuffling around of URLs, because the auth endpoint isn't under api/v1....
There was a problem hiding this comment.
Rather than "automatically copying to clipboard," it would be great if this cli allowed itself to be composed with other command line utilities according to the unix philosophy of small, sharp tools. E.g., if run non-interactively, it could just write the access token to stdout (and any errors or other informational content to stderr). When run interactively, it could include the helpful ...Your access token... content. This would allow simple composition of this and other commands like ... login | pbcopy.
In Ruby, this can be accomplished by testing for STDOUT.tty? but I'm sure there are TS analogs.
| @@ -6,10 +6,30 @@ class Gravity { | |||
| production: "api.artsy.net", | |||
| } | |||
|
|
|||
| async getAccessToken(credentials: Credentials) { | |||
| const gravityUrl = this.url("oauth2/access_token") | |||
There was a problem hiding this comment.
I'd have to dig... is this where Force posts credentials to obtain an access token today?
There was a problem hiding this comment.
This looks great! FWIW, I agree with @joeyAghion that it would be great for this command to be composed with something like pbcopy rather than automagically doing that. Seems more portable to me that way too.
|
I'll modify this to allow piping to |
This is nice because it means you can compose this command with pbcopy or use it in a shell script or whatever.
|
Ok I cloned down this PR, rebased on top of master and then snipped out the extra log statements with c3dab16 so going to merge this. Hope that's ok @pepopowitz!! 🤗 |
|
🚀 PR was released in v0.0.3 🚀 |
|
🚀 PR was released in v0.0.3 🚀 |
2 similar comments
|
🚀 PR was released in v0.0.3 🚀 |
|
🚀 PR was released in v0.0.3 🚀 |
|
Thanks for moving this forward, @jonallured! |
This PR adds the ability to log into stagingapi.artsy.net. The new token is spit out to the console.
Usage
./bin/run loginConsole in/out looks like this:
Caveats
client_idandclient_secretset as environment variables. I've added.envto .gitignore so that you can store them in there. For now, I'm borrowing force's id and secret locally. I added a backlog item to get a proper client id and secret for this app.