Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BioEduModule #1133

Closed
briansw opened this issue Feb 10, 2016 · 6 comments
Closed

BioEduModule #1133

briansw opened this issue Feb 10, 2016 · 6 comments

Comments

@briansw
Copy link
Contributor

briansw commented Feb 10, 2016

bio-edu-module

@briansw
Copy link
Contributor Author

briansw commented Apr 29, 2016

One small adjustment to make here regarding the formatting for the metadata related to the artist:

screen shot 2016-04-29 at 9 11 05 am

@alloy
Copy link
Contributor

alloy commented May 9, 2016

@mzikherman Are you aware of if/where we include by what partner a blurb is written?

@briansw
Copy link
Contributor Author

briansw commented May 9, 2016

@alloy, sorry this slipped my mind for making a note in iOS: We need to hold on implementing partner-submitted bios on the artist view for time being. There's been some talk about needing to review the bios before they appear on the artist view. When there isn't an Artsy bio, we should still return the bioline when possible though.

@alloy
Copy link
Contributor

alloy commented May 9, 2016

Ok, that makes sense, but I’m still unsure whether that means the blurb from the artists endpoint is such a bio and/or if the API will return it at all if it still needs review. /cc @mzikherman

@alloy
Copy link
Contributor

alloy commented May 29, 2016

  • We don’t have the name of the partner that submitted yet.
  • We don’t have the collapse/expand functionality yet, I think we should defer that until we have the other metadata.

@alloy
Copy link
Contributor

alloy commented Feb 7, 2017

@mzikherman We have all of this data nowadays, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants