feat: show Purchase button properly on artwork screen when there is a partner offer #10144
Conversation
| @@ -60,7 +60,119 @@ describe("ArtworkCommercialButtons", () => { | |||
| `, | |||
| }) | |||
|
|
|||
| it("renders Make Offer button if isOfferable", async () => { | |||
| describe("with partner offer on artwork screen feature flag turned off", () => { | |||
There was a problem hiding this comment.
Grouping the test cases when feature flag is disabled here to hopefully just delete it entirely when the feature flag is retired.
| }) | ||
|
|
||
| it("renders Purchase button if isAcquireable", async () => { | ||
| it("renders Contact Gallery button if artwork is only inquireable", async () => { |
There was a problem hiding this comment.
The updated test cases are
ArtworkCommercialButtons
✓ renders Purchase button if artwork is only acquireable
✓ renders Purchase button if artwork is only acquireable and with a partner offer
✓ renders Make an Offer button if artwork is only offerable
✓ renders Contact Gallery button if artwork is only inquireable
✓ renders Purchase and Make an Offer buttons if artwork is offerable and acquireable
✓ renders Purchase and Make an Offer buttons if artwork is only offerable and with a partner offer
✓ renders Purchase and Make an Offer buttons if artwork is offerable and acquireable and with a partner offer
✓ renders Make an Offer and Contact Gallery buttons if artwork is offerable and inquireable
✓ renders Purchase and Contact Gallery buttons if artwork is offerable and inquireable and with a partner offer
✓ renders Bid button if artwork is in acution and biddable
✓ renders Purchase and Bid buttons if artwork is in auction and buynowable
with partner offer on artwork screen feature flag turned off
✓ renders Purchase button if artwork is only acquireable and with a partner offer
✓ renders Make an Offer button if artwork is only offerable and with a partner offer
✓ renders Purchase and Make an Offer buttons if artwork is offerable and acquireable and with a partner offer
✓ renders Make an Offer and Contact Gallery buttons if artwork is offerable and inquireable and with a partner offer
| expect(screen.getByText("Make an Offer")).toBeTruthy() | ||
| expect(screen.queryByText("Contact Gallery")).toBeFalsy() |
There was a problem hiding this comment.
Updated the tests to explicitly check inapplicable CTAs are not present.
| }) | ||
|
|
||
| it("renders Bid button if isInAuction & isBiddable", async () => { | ||
| it("renders Purchase and Make an Offer buttons if artwork is only offerable and with a partner offer", async () => { |
There was a problem hiding this comment.
This is the first behavioral change.
| Before | After | |
|---|---|---|
 |
 |
| expect(screen.queryByText("Contact Gallery")).toBeFalsy() | ||
| }) | ||
|
|
||
| it("renders Make an Offer and Contact Gallery buttons if artwork is offerable and inquireable", async () => { |
There was a problem hiding this comment.
This is the second behavioral change. When there is already Make Offer and Contact Gallery buttons, and there is a partner offer associated, we want to prioritize the Purchase button (for the partner offer) over Make an Offer (see discussion).
| Before | After | |
|---|---|---|
 |
 |
| const artworkData = useFragment(artworkFragment, artwork) | ||
| const meData = useFragment(meFragment, me) | ||
| const partnerOfferData = useFragment(partnerOfferFragment, partnerOffer) | ||
| const isPartnerOffered = AREnablePartnerOfferOnArtworkScreen && !!partnerOfferData |
There was a problem hiding this comment.
Guard it behind the feature flag.
| @@ -108,6 +111,19 @@ export const ArtworkCommercialButtons: React.FC<ArtworkCommercialButtonsProps> = | |||
| } | |||
|
|
|||
| if (artworkData.isInquireable && artworkData.isOfferable) { | |||
| if (isPartnerOffered) { | |||
There was a problem hiding this comment.
The existing if/else approach to exhaust all possibilities seems easy to miss some cases. I'm not doing big structural changes in this PR but could be an opportunity for improvement in a followup.
|
@MrSltun Since we are approaching code freeze tomorrow and I'm in timezone that's behind, I assigned this PR to you. Before I sign on tomorrow, please feel free to push new changes or merge! 🙏 |
starsirius
changed the title
This PR resolves EMI-1844
Description
Purchase button was not properly displayed on artwork screen in some cases when the artwork had a partner offer. This PR updates the logic and expands the test cases to cover (hopefully) all major scenarios.
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.